Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karton v5.4.0 optimizations #83

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented May 16, 2024

  • Shortening fully-qualified task uids coming from v5.4.0
  • state.get_analysis instead of state.analyses.get is used for getting analysis status. This method is faster as it doesn't deserialize all tasks in Redis

@psrok1 psrok1 marked this pull request as ready for review May 16, 2024 15:39
@psrok1 psrok1 requested review from msm-cert and nazywam May 16, 2024 15:41
Copy link
Member

@nazywam nazywam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok in karton-playground

@psrok1 psrok1 merged commit a4a0e3e into master May 20, 2024
5 checks passed
@psrok1 psrok1 deleted the feature/karton-v5.4.0-optimizations branch May 20, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants