Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard can be served on a non-root path #79

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

kazet
Copy link
Member

@kazet kazet commented Jan 11, 2024

No description provided.

@psrok1 psrok1 marked this pull request as draft January 11, 2024 11:18
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is more generic way than pasting base path everywhere e.g. blueprints + changing templates to accept another base path than /.

@kazet kazet requested a review from psrok1 January 12, 2024 17:54
@kazet kazet marked this pull request as ready for review January 12, 2024 17:55
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK! Tested manually with default and custom base path.

karton/dashboard/app.py Outdated Show resolved Hide resolved
@psrok1 psrok1 merged commit 8b2a11c into CERT-Polska:master Jan 17, 2024
5 checks passed
msm-cert added a commit that referenced this pull request Feb 8, 2024
Dashboard can now be served on a non-root path (#79)
Added support for ARM
@msm-cert msm-cert mentioned this pull request Feb 8, 2024
psrok1 pushed a commit that referenced this pull request May 14, 2024
Dashboard can now be served on a non-root path (#79)
Added support for ARM
@psrok1
Copy link
Member

psrok1 commented May 14, 2024

Wait... actually it should be minor bump, not bugfix 🤔

@psrok1 psrok1 mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants