Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making num_check_lips=0 #172

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Making num_check_lips=0 #172

merged 1 commit into from
Mar 6, 2024

Conversation

chaithyagr
Copy link
Contributor

This fixes #171

paquiteau
paquiteau approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chaithyagr chaithyagr merged commit 4e2489e into develop Mar 6, 2024
0 of 2 checks passed
@chaithyagr chaithyagr deleted the num_check_lips branch March 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paquiteau paquiteau paquiteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the default of 10 for num_check_lips
2 participants
@chaithyagr @paquiteau