Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate suggestions from JOSS review #60

Merged
merged 6 commits into from
Dec 21, 2024

Conversation

CDJellen
Copy link
Owner

Summary of core changes:

  • Improve the default response format of available_realtime to return a list of the modes supported by a given station. full_response=True returns the URLs for available station, optionally as a dataframe.
  • Update the parameters in API methods to reflect the migration from the netCDF4 package to the xarray package.
  • Expose xarray keyword arguments to the save_xarray_dataset method.

Bugfixes:

  • None noted; some documentation updates to better reflect what parameters are used.

Future improvements:

  • None noted.

@CDJellen CDJellen added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 20, 2024
@CDJellen CDJellen self-assigned this Dec 20, 2024
@CDJellen CDJellen merged commit d62f4e9 into main Dec 21, 2024
4 checks passed
@CDJellen CDJellen deleted the user/cjellen/joss-suggested-improvements branch December 21, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant