-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small README changes #56
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f0125a7
Add test instructions to contributing
rwegener2 88aafb0
Fix typo in Station measurements
rwegener2 b129655
README cleanup
CDJellen 0611354
Add new CONTRIBUTING.md guide
CDJellen ceade1b
improve the introduction for the API in the README
CDJellen b99e214
add mode descriptions
CDJellen cca6814
Include mode explainers
CDJellen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#### Contributing | ||
|
||
The `ndbc-api` is actively maintained, please feel free to open a pull request if you have any suggested improvements, test coverage is strongly preferred. | ||
|
||
##### Testing | ||
|
||
Tests are prepared and executed using the `pytest` framework, and designed to use cached responses rather than making new HTTP requests to the NDBC Data Service. In order to run tests, you will need to install the additional packages in `requirements_dev.txt` (also encoded in the `dev` group in `pyproject.toml`) | ||
|
||
For pip installation, please create a clean virtual environment and run: | ||
|
||
```bash | ||
pip install -r requirements.txt | ||
pip install -r requirements_dev.txt | ||
``` | ||
|
||
For poetry-managed installations, please run: | ||
|
||
```bash | ||
poetry install | ||
``` | ||
|
||
##### Running Tests | ||
|
||
All tests can be run from the root directory using `python3 -m pytest --run-slow --run-private`. | ||
|
||
The two flags in the command above are optional, but can be useful for running all tests, including those marked as slow or private. The `--run-slow` flag will run tests marked with the `@pytest.mark.slow` decorator, and the `--run-private` flag will run tests marked with the `@pytest.mark.private` decorator. Tests which take more than 30 seconds are typically marked as slow, while test for internals are marked as private. | ||
|
||
##### Pull Requests | ||
|
||
In order for a pull request to merge to `main`, all tests must pass, and the code must be reviewed by at least one other contributor. | ||
|
||
Breaking changes will be considered, especially in the current `alpha` state of the package on `PyPi`. As the API further matures, breaking changes will only be considered with new major versions (e.g. `N.0.0`). | ||
|
||
Alternatively, if you have an idea for a new capability or improvement, feel free to open a feature request issue outlining your suggestion and the ways in which it will empower the atmospheric research community. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 83 is really interesting, but I worry it is a bit dense for someone with less programming background. I would consider adding some higher level text before the denser paragraph, for example maybe
"
NdbcApi
provides a singular access point for NDBC data. All the methods for finding data, metadata, and locating stations are available using theapi
object."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this suggestion; I agree and have included this change in the PR you opened.
While I enjoyed building these features when initially designing the API, they are all but irrelevant to end users.
Additionally, I've split off the test instructions into a new
CONTRIBUTING.md
guide.