Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 537: Fix making analysis dataframes and record priors #535

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 commented Dec 9, 2024

This draft PR is for tracking changes to the EpiAwarePipeline code base done in order to run the full pipeline and to fix unanticipated changes in the analysis code.

I've decided to upgrade the work so far to a full PR. This PR closes #537 and contributes to #405.

Tasks so far

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="latest-analysis", subdir="EpiAware")
using EpiAware

_make_epidata can also be reused elsewhere
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (5274760) to head (a9e823e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          57       57           
  Lines         825      825           
=======================================
  Hits          747      747           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelBrand1
Copy link
Collaborator Author

This PR modifies the make_prediction_dataframe_from_output function to:

  1. Fix the function interface to the output data structure by responding to pipeline changes.
  2. Use new inference_config rather than logic on the filename of serialised object.

This PR also adds a small "test data" in the correct format for use in unit testing. From f2f discussion with @seabbs this is a temporary solution until we make a test which generates its own test data.

@SamuelBrand1 SamuelBrand1 marked this pull request as ready for review December 9, 2024 14:56
@SamuelBrand1
Copy link
Collaborator Author

I was thinking about breaking this up, but I didn't like the sequence and ended up with a with set of commits.

@SamuelBrand1 SamuelBrand1 requested a review from seabbs December 9, 2024 14:59
@SamuelBrand1 SamuelBrand1 changed the title Draft PR: Latest analysis Issue 537: Fix making analysis dataframes and record priors Dec 9, 2024
@seabbs seabbs enabled auto-merge December 9, 2024 15:31
@seabbs seabbs added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 8c05d03 Dec 9, 2024
10 checks passed
@seabbs seabbs deleted the latest-analysis branch December 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants