-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 537: Fix making analysis dataframes and record priors #535
Conversation
Try this Pull Request!Open Julia and type: import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="latest-analysis", subdir="EpiAware")
using EpiAware |
_make_epidata can also be reused elsewhere
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 90.54% 90.54%
=======================================
Files 57 57
Lines 825 825
=======================================
Hits 747 747
Misses 78 78 ☔ View full report in Codecov by Sentry. |
And add simple unit test with committed test data
This reverts commit 7e6238b.
This PR modifies the
This PR also adds a small "test data" in the correct format for use in unit testing. From f2f discussion with @seabbs this is a temporary solution until we make a test which generates its own test data. |
This reverts commit 14d29b4.
I was thinking about breaking this up, but I didn't like the sequence and ended up with a with set of commits. |
This draft PR is for tracking changes to theEpiAwarePipeline
code base done in order to run the full pipeline and to fix unanticipated changes in the analysis code.I've decided to upgrade the work so far to a full PR. This PR closes #537 and contributes to #405.
Tasks so far
make_prediction_dataframe_from_output
function to implement changes to saved objects due to Upgrade thetestmode
pipeline script to pipeline scripts: prior predictive + full #445. This closes Issue 536: Fix make dataframe function #537