Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to LERC-3 #199

Closed
wants to merge 1 commit into from
Closed

Pin to LERC-3 #199

wants to merge 1 commit into from

Conversation

SamuelBrand1
Copy link
Collaborator

Does as says to fix #198 .

NB: This might be duplicating the Julia registry pin here.

Closes #198

@SamuelBrand1 SamuelBrand1 requested a review from seabbs May 1, 2024 13:21
@SamuelBrand1 SamuelBrand1 linked an issue May 1, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (5e2bbee) to head (aa39f9c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          38       38           
  Lines         368      368           
=======================================
  Hits          339      339           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs
Copy link
Collaborator

seabbs commented May 1, 2024

It looks like this doesn't fix it? Shall we see if the central change does the job?

We have a CI error for an outlier negative binomial sample now!

@SamuelBrand1
Copy link
Collaborator Author

Hmmm I think this issue is already fixed by giordano-patch-1 merging into the Julia registry... still want to add a pinned version?

@SamuelBrand1
Copy link
Collaborator Author

I'm closing this because I think the central change is a better way to go

@SamuelBrand1 SamuelBrand1 deleted the 198-lerc-40-incompatibility branch October 17, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LERC-4.0 incompatibility
3 participants