Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTR Notification: Make notification_uid not optional in Kafka message schema #47

Merged
merged 1 commit into from
Oct 1, 2024
Merged

RTR Notification: Make notification_uid not optional in Kafka message schema #47

merged 1 commit into from
Oct 1, 2024

Conversation

sveselev
Copy link
Collaborator

@sveselev sveselev commented Oct 1, 2024 •
edited by upasanapattnaik-eq
Loading

Notes

Fix schema for nrt_investigation_notification payload to set optional: false for notification_uid

Types of changes

  • Bugfix

Testing

  • PR has >90% code coverage

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

alog-enquizit
alog-enquizit approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@alog-enquizit alog-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sveselev sveselev merged commit afeb150 into main Oct 1, 2024
2 checks passed
@sveselev sveselev deleted the rtr-kafka-sink-nrt-inv-notification-schema-fix branch October 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alog-enquizit alog-enquizit alog-enquizit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveselev @alog-enquizit