Issu#136 region #22
Merged
Issu#136 region #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is failing due to "Ruby" will try to rebuild when Travis fix it. |
|
We can no longer use the "... since 0" as unit since year 0 is not CF-1 compliant. I changed all tests and test_file |
|
I also warned the users about the select_region and created a tests for ticket #22 |
doutriaux1
reviewed
Feb 6, 2018
|
|
||
| language: python | ||
|
|
||
| python: |
There was a problem hiding this comment.
@dnadeau4 why do we need this? Does it run the test twice now?
There was a problem hiding this comment.
I got it from UV-CDAT.
There was a problem hiding this comment.
I removed python 3.6 since we already do both version in the conda env.
There was a problem hiding this comment.
@doutriaux1 Can you merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.