-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mingle python 2 and 3 with ifdef #19
Conversation
@dnadeau4 this looks great. Thanks! In the test . I think we need to add some tests for comp<rel rel<comp etc... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnadeau4 I think we need to add some rl vs comp and comp vs rel tests and some == tests, just to be safe.
@doutriaux1 please merge. |
@dnadeau4 please make sure we had tests for comptime vs reltime etc... as requested in my review. It's important to make sure this works. |
Can you make another issue for the tests? This bug is solved. |
I'll add the tests myself when I get to this... Hopefully tomorrow... I would rather the branch to be complete before merging in. |
@doutriaux1 can you merge? |
I still need to add the test. Can this wait just another day? |
@dnadeau4 good thing I checked and added tests. My new tests fail. Back to to drawing board 😢 |
No description provided.