Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixes BUILDINSOURCE detection" #797

Merged
merged 1 commit into from
Oct 13, 2014
Merged

Conversation

aashish24
Copy link
Contributor

Reverts #791

@aashish24
Copy link
Contributor Author

@doutriaux1 I am reverting this change.

aashish24 added a commit that referenced this pull request Oct 13, 2014
Revert "Fixes BUILDINSOURCE detection"
@aashish24 aashish24 merged commit d4be3a8 into master Oct 13, 2014
@aashish24 aashish24 deleted the revert-791-build-in-source branch October 13, 2014 19:54
@williams13
Copy link
Contributor

Why are we doing this so late in the game? I thought that we had this right. I tested it on my 10.8.5 and it built cleanly. Can others sound off on the other supported platforms to make sure it builds?

@aashish24
Copy link
Contributor Author

@williams13 You are right. We shouldn't be merging branch at this time. @remram44 pushed a fix which broke the build for Brian. I reverted @remram44 change as it didn't work.

@remram44
Copy link
Contributor

I tagged it as "2.1" for a reason... What are you doing... Is 2.0 out, it got tagged on Friday?

@williams13
Copy link
Contributor

Please!!! I have enough grey hair… :-) No more changes!!!! Tag it and everything else goes into 2.1…

Thanks everyone for working hard on this to get it out… :-)

@williams13
Copy link
Contributor

Charles did you finish the 2.0 tag and mirrored it at the other sites?

@aashish24
Copy link
Contributor Author

@williams13 we just had to move the tag to include @ThomasMaxwell changes. Everything else is tagged (vistrails and uvcmetrics).

@aashish24
Copy link
Contributor Author

@remram44 let's discuss this issue, after we put the tarball on the sourceforge.

@remram44
Copy link
Contributor

Reopened as #798. Milestone "2.1" means "not 2.0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants