-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fixes BUILDINSOURCE detection" #797
Conversation
@doutriaux1 I am reverting this change. |
Revert "Fixes BUILDINSOURCE detection"
Why are we doing this so late in the game? I thought that we had this right. I tested it on my 10.8.5 and it built cleanly. Can others sound off on the other supported platforms to make sure it builds? |
@williams13 You are right. We shouldn't be merging branch at this time. @remram44 pushed a fix which broke the build for Brian. I reverted @remram44 change as it didn't work. |
I tagged it as "2.1" for a reason... What are you doing... Is 2.0 out, it got tagged on Friday? |
Please!!! I have enough grey hair… :-) No more changes!!!! Tag it and everything else goes into 2.1… Thanks everyone for working hard on this to get it out… :-) |
Charles did you finish the 2.0 tag and mirrored it at the other sites? |
@williams13 we just had to move the tag to include @ThomasMaxwell changes. Everything else is tagged (vistrails and uvcmetrics). |
@remram44 let's discuss this issue, after we put the tarball on the sourceforge. |
Reopened as #798. Milestone "2.1" means "not 2.0". |
Reverts #791