checking wrong part of version for OS SDK determination #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about that and I thought you were getting 8,9, 10. I think we need a Mac buildbot. |
aashish24
added a commit
that referenced
this pull request
May 14, 2015
checking wrong part of version for OS SDK determination
|
thanks @aashish24 if you send me instructions, I can set a few mac buildbots |
|
Okay, thanks. I will. That's why i wanted to merge any pending branch we had #1312. Once that's in, I will clear the master and also finalize the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aashish24 @jbeezley I was checking MAJOR rather than MINOR for OSX version and I had a typo anyway. Please review and merge asap so we can tag 2.2.0