Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Remove pytest-catchlog from dependences. #961

Merged
merged 2 commits into from
Feb 20, 2018

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Feb 15, 2018

We've been getting warnings about it having been merged into pytest
core, e.g:

https://travis-ci.org/CCI-MOC/hil/jobs/341455006#L2725

This also bumps the minimum version for pytest in our setup.py, since
the change was made in 3.3.0:

We've been getting warnings about it having been merged into pytest
core, e.g:

    https://travis-ci.org/CCI-MOC/hil/jobs/341455006#L2725

This also bumps the minimum version for pytest in our setup.py, since
the change was made in 3.3.0:

* https://docs.pytest.org/en/latest/changelog.html#id56
* pytest-dev/pytest#2794
@naved001
Copy link
Contributor

naved001 commented Feb 16, 2018

I tried doing this in #927 and when I removed pytest-catchlog from the requirements, it suddenly couldn't import it. So don't know what's up with that.

From my description there:

One message that is still annoying is this:

=============================================================================================== warnings summary ===============================================================================================
None
  pytest-catchlog plugin has been merged into the core, please remove it from your requirements.

-- Docs: http://doc.pytest.org/en/latest/warnings.html

I removed pytest-catchlog from the requirements, but then I couldn't import pytest_catchlog. Their docs don't say anything about it being merged into the core, it still tells you to install it explicitly. Don't know what's up with that.

This is likely responsible for the test failures.
@zenhack
Copy link
Contributor Author

zenhack commented Feb 19, 2018

@naved001, found the problem, see the last commit. D'oh.

Copy link
Contributor

@xuhang57 xuhang57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naved001 naved001 merged commit e312fb6 into CCI-MOC:master Feb 20, 2018
@zenhack zenhack deleted the pytest-catchlog branch July 27, 2018 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants