Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 4.8 and Fix TLS issue #12

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

Tarun-Arora
Copy link
Contributor

Since .NET 4.0 is no longer supported, it would be better if we upgrade to higher version.

Also please include CCExtractor.exe.config in the release and the following script for running tester on linux:

#!/bin/bash
exec mono CCExtractorTester.exe "$@"

@canihavesomecoffee
Copy link
Member

You can add those files and modify the workflow yourself as well :)

@canihavesomecoffee
Copy link
Member

Can you add that stub script as a file and include it in the release workflow? I guess that makes more sense than adding it to the readme?

@Tarun-Arora
Copy link
Contributor Author

Can you add that stub script as a file and include it in the release workflow? I guess that makes more sense than adding it to the readme?

Moving the script as a file was okay, but should a static script be included in the release? Like it would not be useful for windows users also...

@Tarun-Arora
Copy link
Contributor Author

@thealphadollar This PR has been raised corresponding to the issue faced during CCExtractor/sample-platform#702.

@canihavesomecoffee canihavesomecoffee merged commit e4893e9 into CCExtractor:master Dec 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants