Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7, [Feat] Spring Project Init 및 TestController 작성 #9

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

kimyoungi99
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Youhoseong Youhoseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커밋 컨벤션을 정해야 될 것 같네요

++ 이슈 번호를 커밋에 남기면 이슈에 기록 남아서 좋아요. (ex. #7)

Comment on lines 9 to 11
public static void main(String[] args) {
SpringApplication.run(BridgeApplication.class, args);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 탭이 한 칸 더 들어간 것 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해결 했습니당~ (4space)

Comment on lines +9 to +15
public class TestController {

@GetMapping
public String helloWorld() {
return "Hello, World!";
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기가 덜 들어간건가 ㅎㅎ

@kimyoungi99 kimyoungi99 merged commit b0223b3 into main Jun 13, 2022
@kimyoungi99 kimyoungi99 deleted the Issue-7 branch June 13, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants