[Feat] 닉네임 등록 API #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heoboseong7 이거 리뷰해도되는 상태에요지금~?~? |
Youhoseong
approved these changes
Jul 10, 2022
| @ExceptionHandler(IllegalArgumentException.class) | ||
| @ResponseStatus(BAD_REQUEST) | ||
| public ApiResponse<?> handleIllegalArgumentException(IllegalArgumentException ex) { | ||
| log.info("handleIllegalArgumentException: {}", ex.getMessage(), ex); |
There was a problem hiding this comment.
에러로그는 log.error로 하는게 좋아보입니당 (나중에 로그 레벨 별로 알람 처리 예정)
|
|
||
| @PostMapping("/link") | ||
| public Long createLink() { | ||
| return profileService.createLink(new CreateLinkDto(4L, "hs")); |
| @ResponseStatus(BAD_REQUEST) | ||
| public ApiResponse<?> handleIllegalArgumentException(IllegalArgumentException ex) { | ||
| log.info("handleIllegalArgumentException: {}", ex.getMessage(), ex); | ||
| return ApiResponse.failure(KeeweRtnConsts.ERR400, ex.getMessage()); |
There was a problem hiding this comment.
KeeweRtnConsts가 고정된 형태가 아니라 외부에서 들어온값을 써야되는 형태가 돼야될듯한데
나중에 정리하면서 얘기해보시져 ㅎ
Comment on lines
-46
to
-47
| throw new KeeweAuthException(KeeweRtnConsts.ERR401); | ||
|
|
There was a problem hiding this comment.
else로 분기처리 돼야되는부분 -> 이건 제쪽에서 처리함.
| @@ -12,6 +12,7 @@ public enum KeeweRtnConsts { | |||
| ERR402(KeeweRtnGrp.Auth, 402, "토큰이 만료됐어요."), | |||
| ERR403(KeeweRtnGrp.Auth, 403, "토큰이 누락됐어요."), | |||
|
|
|||
| ERR400(KeeweRtnGrp.Validation, 400, "잘못된 요청이에요."), | |||
There was a problem hiding this comment.
이건 너무 애매한 응답 메시지 같은데.. 이것도 ExceptionAdvice랑 같이 얘끼해보시져 이따가
Comment on lines
+107
to
+120
| private boolean isCreatingOrElseThrow() { | ||
| if (this.profileStatus.getOrder() >= ACTIVE.getOrder()) { | ||
| throw new IllegalStateException("프로필 생성이 이미 완료되었습니다."); | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| private void checkNicknameLength(String nickname) { | ||
| final int NICKNAME_MAX_LENGTH = 12; | ||
| if (StringLengthUtil.getGraphemeLength(nickname) > NICKNAME_MAX_LENGTH) { | ||
| throw new IllegalArgumentException("닉네임의 길이가 12자를 초과해요."); | ||
| } | ||
| } |
There was a problem hiding this comment.
이것도 향후에는 전부 KeeweRtnConsts와 KeeweException으로 관리해야됩니다
| Boolean existsByLinkAndDeletedFalse(String link); | ||
|
|
||
| default Profile findByIdAndUserIdAndDeletedFalseOrElseThrow(Long id, Long userId) { | ||
| return findByIdAndUserIdAndDeletedFalse(id, userId).orElseThrow(() -> new IllegalArgumentException("허보성 바보")); |
There was a problem hiding this comment.
얘도 KeeweException & KeeweRtnConsts
Comment on lines
20
to
25
| @PostMapping | ||
| public String tempLogin(@RequestBody String email) { | ||
| System.out.println("email = " + email); | ||
| List<String> roles = new ArrayList<>(); | ||
| return jwtUtils.createToken(email, roles); | ||
| } |
There was a problem hiding this comment.
이거는 지워버리고 올릴게요
Comment on lines
+19
to
+21
| KeeweRtnConsts.NRM000, | ||
| KeeweRtnConsts.NRM000.getDescription(), | ||
| KeeweRtnConsts.NRM000.getCode(), |
There was a problem hiding this comment.
성공코드도 여러개가있을수있어요 외부 주입으로 변경돼야할듯한데 같이 논의대상
|
|
||
| private void checkDuplicateLinkOrElseThrows(String link) { | ||
| if (profileRepository.existsByLinkAndDeletedFalse(link)) | ||
| throw new IllegalArgumentException("허보성 바보!!"); |
There was a problem hiding this comment.
영기파트?? KeeweRtnConsts & Exception 처리 대상
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31