Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 팔로잉/팔로워 검색 API #334

Merged
merged 5 commits into from
Jun 11, 2023
Merged

[Feat] 팔로잉/팔로워 검색 API #334

merged 5 commits into from
Jun 11, 2023

Conversation

heoboseong7
Copy link
Collaborator

관련 Issue

작업 내용

  • 초대 대상 (팔로잉/팔로워) 닉네임 검색 API를 개발했어요

Figma 링크

image

@heoboseong7 heoboseong7 added enhancement New feature or request feature labels Jun 4, 2023
@heoboseong7 heoboseong7 self-assigned this Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

테스트통과 🤖

Copy link
Collaborator

@Youhoseong Youhoseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

닉넴이 유니크하지 않은데 괜찮으려나요 ?

Comment on lines +10 to +13
public class InviteeSearchResponse {
// 응답의 닉네임 중 사전순 가장 뒤
private String nextCursor;
private List<InviteeResponse> invitees;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 커서 페이지네이션 응답 구조도 공통화 해볼 수 있겠네요 ~

@heoboseong7
Copy link
Collaborator Author

닉넴이 유니크하지 않은데 괜찮으려나요 ?

인덱스 때문인가요?

@Youhoseong
Copy link
Collaborator

Youhoseong commented Jun 10, 2023

데이터 순서가 만약
page1

마지막데이터: 호성 <-

page 2
첫번째 데이터: 호성
...

이면 페이지네이션이 꼬이지않을까요?

@heoboseong7
Copy link
Collaborator Author

아하 무슨 말씀인지 이해했어요
페이지의 모든 닉네임이 같은 경우에는 무한 루프도 가능하겠네요
커서랑 정렬 조건에 userId 넣는 방향으로 고려해봐야겠네요 ㅠ

@github-actions
Copy link

다시짜 🤖

@github-actions
Copy link

테스트통과 🤖

@heoboseong7 heoboseong7 merged commit 0b4ed3a into main Jun 11, 2023
@heoboseong7 heoboseong7 deleted the issue-#333 branch June 11, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 팔로잉/팔로워 검색 API
2 participants