Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 최초 회원가입 타이틀 획득 버그 수정 #331

Merged
merged 1 commit into from
Jun 3, 2023
Merged

[Fix] 최초 회원가입 타이틀 획득 버그 수정 #331

merged 1 commit into from
Jun 3, 2023

Conversation

Youhoseong
Copy link
Collaborator

관련 Issue

  • 회원가입 타이틀 획득 버그를 수정해요.

작업 내용

  • Tx Commit되는 시점에 유저 정보가 데이터베이스에 저장되기때문에, 타이틀 획득 이벤트를 발행하고 statistics 모듈에서 타이틀 획득처리할 때 유저 정보가 없을 수 있어요.
  • Tx가 필요하지 않다고도 판단되어서, 제거하였고 JPA 쓰기 지연이 작동하지 않도록 수정했어요

@Youhoseong Youhoseong added the bug Something isn't working label Jun 3, 2023
@Youhoseong Youhoseong self-assigned this Jun 3, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

테스트통과 🤖

heoboseong7
heoboseong7 approved these changes Jun 3, 2023
View reviewed changes
Copy link
Collaborator

@heoboseong7 heoboseong7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쓰기 지연때문에 이렇게도 되네요 ㄷㄷ
LGTM 👍

@Youhoseong Youhoseong merged commit 2022bda into main Jun 3, 2023
@Youhoseong Youhoseong deleted the fix/title-acquire-bug branch June 3, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heoboseong7 heoboseong7 heoboseong7 approved these changes

@kimyoungi99 kimyoungi99 Awaiting requested review from kimyoungi99

Assignees

@Youhoseong Youhoseong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youhoseong @heoboseong7