[Feat] 참여 인원이 없는 챌린지 deleted 처리 배치 개발 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
테스트통과 🤖 |
|
1일마다 스케쥴링을 걸어놓고 시간 정보를 활용한다면 |
|
@heoboseong7 이건 분 배치로 돌릴거같아요. 실시간 성이 보장되어야해서요! |
|
@Youhoseong 그러면 분 단위로만 바꿔서 적용하면 될 것 같아요
-> 그래서 변경된 챌린지 참가를 찾은 다음, 연관된 챌린지를 찾아야 해요 |
|
@heoboseong7 챌린지 참가 -> 챌린지랑 그거랑 엮인 모든 챌린지 참가 조회 이 구조? |
|
@Youhoseong 네 맞아요! |
|
@heoboseong7 적용했어요! 리뷰 고고 |
|
테스트통과 🤖 |
heoboseong7
approved these changes
May 1, 2023
Comment on lines
28
to
30
| public List<Challenge> paginateWithParticipation(CursorPageable<Long> cPage) { | ||
| return challengeQueryRepository.paginateWithParticipation(cPage); | ||
| } |
There was a problem hiding this comment.
이 메서드 관련해서 사용하지 않는 코드들은 삭제해도 될 것 같아요
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
참여 인원이 없는 챌린지 deleted 처리 배치 개발했어요.
범위 조회를 하고 싶어서 시간 파라미터를 넣고 싶은데요.
시간 흐름에 따라 deleted 처리되는 건 아니다 보니까 활용을 어캐해야될지 생각이 잘안나네요
다른 방법이더라도 데이터 스캔 범위를 어캐 해볼 수 있을지 의견 주시면 좋을거같아요!