[Feat] 차단한 유저에 대한 요청 필터링 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
테스트통과 🤖 |
Youhoseong
reviewed
Apr 16, 2023
Comment on lines
21
to
28
| public BlockFilterAspect(ProfileQueryDomainService profileQueryDomainService, InsightQueryDomainService insightQueryDomainService) { | ||
| this.profileQueryDomainService = profileQueryDomainService; | ||
| this.insightQueryDomainService = insightQueryDomainService; | ||
| } | ||
|
|
||
| private final ProfileQueryDomainService profileQueryDomainService; | ||
| private final InsightQueryDomainService insightQueryDomainService; | ||
| private final ThreadLocal<Set<Long>> blockedUserIdsStore = new ThreadLocal<>(); |
There was a problem hiding this comment.
Suggested change
| public BlockFilterAspect(ProfileQueryDomainService profileQueryDomainService, InsightQueryDomainService insightQueryDomainService) { | |
| this.profileQueryDomainService = profileQueryDomainService; | |
| this.insightQueryDomainService = insightQueryDomainService; | |
| } | |
| private final ProfileQueryDomainService profileQueryDomainService; | |
| private final InsightQueryDomainService insightQueryDomainService; | |
| private final ThreadLocal<Set<Long>> blockedUserIdsStore = new ThreadLocal<>(); | |
| private final ProfileQueryDomainService profileQueryDomainService; | |
| private final InsightQueryDomainService insightQueryDomainService; | |
| private final ThreadLocal<Set<Long>> blockedUserIdsStore = new ThreadLocal<>(); | |
| public BlockFilterAspect(ProfileQueryDomainService profileQueryDomainService, InsightQueryDomainService insightQueryDomainService) { | |
| this.profileQueryDomainService = profileQueryDomainService; | |
| this.insightQueryDomainService = insightQueryDomainService; | |
| } | |
There was a problem hiding this comment.
blockedUserIdRegistry는 어때요?
Comment on lines
+73
to
+75
| if (blockedUserIds.contains(response)) { | ||
| throw new KeeweException(KeeweRtnConsts.ERR453); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (blockedUserIds.contains(response)) { | |
| throw new KeeweException(KeeweRtnConsts.ERR453); | |
| } | |
| if (blockedUserIds.contains(response)) { | |
| blockedUserIdsStore.remove(); | |
| throw new KeeweException(KeeweRtnConsts.ERR453); | |
| } |
Comment on lines
+61
to
62
| Set<Long> blockedUserIds = getBlockedUserIds(); | ||
| responses.removeIf(response -> blockedUserIds.contains(response.getUserId())); |
There was a problem hiding this comment.
Suggested change
| Set<Long> blockedUserIds = getBlockedUserIds(); | |
| responses.removeIf(response -> blockedUserIds.contains(response.getUserId())); | |
| Set<Long> blockedUserIds = getBlockedUserIds(); | |
| responses.removeIf(response -> blockedUserIds.contains(response.getUserId())); | |
| blockedUserIdsStore.remove(); |
Comment on lines
66
to
69
| private void validateInsightId(Long request) { | ||
| Long writerId = insightQueryDomainService.getByIdWithWriter(request).getWriter().getId(); | ||
| validateUserId(writerId); | ||
| } |
There was a problem hiding this comment.
저는 이거 실제로 insightId를 validation한다고 생각하진 않는데 어떠세요?
또 파라미터 이름 request를 좀 더 구체적으로 바꾸면 좋을거같네요
There was a problem hiding this comment.
네. extract method 써서 만들었는데 코드 자체가 좀 이상하네요;;
|
고생하셨어요 👍 케이스가 되게 많네요 |
다시 보니 여러 번 조회할 일이 없겠네요 ㅎㅎ |
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
InsightId 작성자 관련
GET /api/v1/insight{insightId}GET /api/v1/insight/author/{insightId}GET /api/v1/comments/insights/{insightId}/countGET /api/v1/comments/insights/{insightId}/previewPOST /api/v1/reactionGET /api/v1/insight/{insightId}/challenge-recordGET /api/v1/insight/my-page/{userId}요청 대상 userId 관련
GET /api/v1/drawer/{userId}POST /api/v1/user/profile/follow/{userId}GET /api/v1/user/priflie/achieved-title/{userId}GET /api/v1/user/priflie/all-achieved-title/{userId}GET /api/v1/user/profile/followee/{userId}GET /api/v1/user/profile/follower/{userId}