[Feat] 댓글, 답글, 리액션, 팔로우 알림 생성 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
다시짜 🤖 |
|
다시짜 🤖 |
|
테스트통과 🤖 |
heoboseong7
approved these changes
Apr 16, 2023
| Notification notification = Notification.of(insight.getWriter(), NotificationContents.반응, String.valueOf(reaction.getId())); | ||
| notificationCommandDomainService.save(notification); | ||
| } catch (Throwable t) { | ||
| log.warn("[RDS::afterReaction] 팔로우 후 작업 실패 - reactorId({}), insightId({})", reaction.getReactor().getId(), insight.getId(), t); |
There was a problem hiding this comment.
afterReaction에 팔로우 후 작업 실패로 들어가있어요
| Notification notification = Notification.of(comment.getInsight().getWriter(), contents, String.valueOf(comment.getId())); | ||
| notificationCommandDomainService.save(notification); | ||
| } catch (Throwable t) { | ||
| log.warn("[CommentApiService::afterLeaveComment] 댓글 작성 완료 후 작업 실패 - commentId({}), insightId({})", comment.getId(), comment.getInsight().getId(), t); |
There was a problem hiding this comment.
여기만 클래스 명이 풀네임으로 들어간 이유가 있나요?
There was a problem hiding this comment.
아 너무 많은 단어가 있어서 줄이면 구리더라구요
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
Figma