[Feat] 알림 목록 조회 / 알림 읽음 처리 기능 개발 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
다시짜 🤖 |
1 similar comment
|
다시짜 🤖 |
|
테스트통과 🤖 |
heoboseong7
reviewed
Apr 9, 2023
Comment on lines
+22
to
+24
| .where(notification.user.eq(user) | ||
| .and(notification.id.lt(cPage.getCursor())) | ||
| ) |
There was a problem hiding this comment.
쿼리 속도 향상을 위해서 (user_id, notification_id)로 인덱스 추가가 필요해보에요
There was a problem hiding this comment.
notification id로 인덱스를 탈거라서, 지켜보시죠~
There was a problem hiding this comment.
지금 상태에선 괜찮아보여요
제가 생각한 내용은
테이블에 (user_id, notification_id)가 아래처럼 있을 때(키위가 잘 돼서 ㅎㅎ;)
(1, 1000)
...
(1, 2000)
...
(1, 3000)
user id = 1, notification id = 3000 요청이 들어오면
notification_id 인덱스를 타더라도 3000부터 1000까지 모든 레코드를 읽어야 하는 문제였어요
There was a problem hiding this comment.
네 의도 이해는 하고 있어요 ㅎㅎ
keewe-api/src/main/java/ccc/keeweapi/controller/api/notification/NotificationController.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/ccc/keeweapi/service/notification/command/NotificationCommandApiService.java
Show resolved
Hide resolved
...main/java/ccc/keewedomain/service/notification/command/NotificationCommandDomainService.java
Outdated
Show resolved
Hide resolved
|
테스트통과 🤖 |
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
테스트 안해봄 ㅎ
Next TODO: 알림 생성
Figma