Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 폴더 삭제, 수정 API #275

Merged
merged 5 commits into from
Apr 2, 2023
Merged

[Feat] 폴더 삭제, 수정 API #275

merged 5 commits into from
Apr 2, 2023

Conversation

heoboseong7
Copy link
Collaborator

작업 내용

  • 폴더 삭제 API
  • 폴더 수정 API

Figma 링크

@heoboseong7 heoboseong7 self-assigned this Apr 2, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

테스트통과 🤖

Comment on lines +68 to +74
public void delete(User user, Long drawerId) {
Drawer drawer = drawerRepository.findByIdOrElseThrow(drawerId);
drawer.validateOwner(user);
drawer.delete();
insightQueryDomainService.findAllByUserIdAndDrawerId(user.getId(), drawerId)
.forEach(Insight::removeDrawer);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트랜잭션을 여기서 묶어야될거같네요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

테스트통과 🤖

@heoboseong7 heoboseong7 merged commit 72424bc into main Apr 2, 2023
@heoboseong7 heoboseong7 deleted the issue-#273 branch April 2, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants