[Feat] 챌린지 참가 정보 수정 API, 참가중인 챌린지 조회 API 수정 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
테스트통과 🤖 |
Youhoseong
approved these changes
Mar 26, 2023
Comment on lines
+129
to
+132
| participation.getMyTopic(), | ||
| participation.getInsightPerWeek(), | ||
| participation.getDuration(), | ||
| participation.getEndDate().toString(), |
There was a problem hiding this comment.
이미 존재하는 API같은데, 왜 변경되는거에요?
이 API를 여러곳에서 쓰나요?
There was a problem hiding this comment.
챌린지 홈에서 쓰고 있어요. 참가중인 챌린지 정보를 조회하는데 홈이냐 상세이냐에 따라 API를 구분하는게 이상해서 변경으로 진행했어요.
| private String interest; | ||
| private String myTopic; | ||
| private int insightPerWeek; | ||
| private int duration; |
There was a problem hiding this comment.
duration이 화면의 뭘 의미하는건지 잘 모르겠어요.
There was a problem hiding this comment.
화면에서는 참가 기간이에요. 매주 3번 기록 x 4주 여기서 {4}주 에 해당돼요
Comment on lines
169
to
171
| ChallengeParticipation participation = challengeParticipateQueryDomainService.getCurrentChallengeParticipation(SecurityUtil.getUser()); | ||
| ParticipationUpdateDto dto = challengeAssembler.toParticipationUpdateDto(request); | ||
| challengeCommandDomainService.updateParticipation(participation, dto); |
There was a problem hiding this comment.
Dto를 따로 만든김에 participation 정보를 포함해서 뭉치는게 좋지않을까요?
혹은 domain service에서 조회하는 것도 고려할 수 있을거같아요~
There was a problem hiding this comment.
userId를 포함시키는 방법으로 생각해볼게요
|
테스트통과 🤖 |
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
Figma 링크