[Feat] 인사이트 생성 시 챌린지 참가 현황 조회 API 수정 반영 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heoboseong7
commented
Mar 18, 2023
| Period between = Period.between(today, createdAt); | ||
| Period between = Period.between(createdAt, today); |
There was a problem hiding this comment.
거꾸로 넣고 있었네요,,,
|
테스트통과 🤖 |
1 similar comment
|
테스트통과 🤖 |
Youhoseong
approved these changes
Mar 19, 2023
| @@ -159,10 +159,15 @@ public boolean isTodayRecorded(User user) { | |||
| return insightQueryRepository.existByWriterAndCreatedAtBetweenAndValidTrue(user, startDate, endDate); | |||
| } | |||
|
|
|||
| public boolean isThisWeekCompleted(ChallengeParticipation participation) { | |||
| Long validNumber = insightQueryRepository.countValidByParticipation(participation); | |||
| log.info("validNumber = {}, currentWeek = {}, insightPerWeek = {}", validNumber, participation.getCurrentWeek(), participation.getInsightPerWeek()); | |||
There was a problem hiding this comment.
우리 로그찍는거랑 형식 비슷하게 맞춰주시면 좋을듯요!
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
Figma 링크