[Refactor] 챌린지 함께 기록(친구) 페이지네이션 조회 API #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
테스트통과 🤖 |
1 similar comment
|
테스트통과 🤖 |
Youhoseong
approved these changes
Mar 12, 2023
Comment on lines
123
to
142
| public List<TogetherChallengerResponse> getTogetherChallengers(Long challengeId) { | ||
| public List<TogetherChallengerResponse> paginateTogetherChallengers(Long challengeId, Pageable pageable) { |
There was a problem hiding this comment.
TogetherChallenger라는 표현을 화면에서 표현하듯이 그냥 Friends로 표현해보는건어때요?
부사가 마치 형용사처럼 쓰이는게 좀 어색하다고 느껴지는것같아요.
There was a problem hiding this comment.
Friends가 더 적절해보이네요
Comment on lines
+101
to
+102
| .offset(pageable.getOffset()) | ||
| .limit(pageable.getPageSize()) |
There was a problem hiding this comment.
왜 offset기반 페이징하시는건가요~??
There was a problem hiding this comment.
정렬 기준때문에 커서 페이징으로 하면 너무 복잡해져서요
네 다른 이슈에서 브랜치를 따버려서 ㅠ |
|
아! 그리고 단순 의견인데, 이런 수정은 리팩토링이라고 말하기는 힘든 것 같아요. |
|
ㅈㅅ |
|
테스트통과 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
작업 내용
챌린지 함께 기록 API
테스트
PageableHandlerMethodArgumentResolver추가Figma 링크