[Feat] 획득한 타이틀 조회 API #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
heoboseong7
commented
Dec 25, 2022
•
heoboseong7
commented
- 최근 획득한 타이틀 조회 API
- 획득한 타이틀 전체 조회 API
- Security ignoring FORCE_SIGNUP_URL 추가
- test 프로필에 aws 관련 값 추가
Youhoseong
reviewed
Dec 25, 2022
Comment on lines
65
to
66
| public MyPageTitleResponse getMyPageTitles(Long userId) { | ||
| int displayNumber = 3; |
There was a problem hiding this comment.
요런 값들은 KeeweConsts에서 관리하면 좋을거같아요~
Youhoseong
reviewed
Dec 25, 2022
Comment on lines
28
to
29
| .orderBy(titleAchievement.createdAt.desc()) | ||
| .limit(n) |
There was a problem hiding this comment.
limit이 어떤 역할을 하는건가요? Integer MAX_VALUE인듯한데
|
conflict 확인해주세요.ㅎㅎ 죄송 |
|
conflict 처리와 test 프로필에 aws 관련 값 추가됐습니다 |
이거 어짜피 다 로컬로 임시로 따놓은거라 나중에 티켓 따로 파서 수정해 놓을게연 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.