[Infra] S3 이미지 스토어 링크 & 프로필 이미지 업로드 API 예시 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TODO : 이미지 접근 권환 수정 - TODO : 이미지 수정 시(POST? PUT?)
|
권환설정 완료 |
|
지원 파일 타입 정하고, 체크하는 로직 필요 (ex jpg 등...) |
kimyoungi99
changed the title
heoboseong7
reviewed
Dec 18, 2022
Comment on lines
1
to
2
| ALTER TABLE insight | ||
| ADD COLUMN image VARCHAR(255) NOT NULL |
Comment on lines
+15
to
+22
| @Value("${cloud.aws.credentials.accessKey}") | ||
| private String accessKey; | ||
|
|
||
| @Value("${cloud.aws.credentials.secretKey}") | ||
| private String secretKey; | ||
|
|
||
| @Value("${cloud.aws.region.static}") | ||
| private String region; |
There was a problem hiding this comment.
어짜피 로컬 세팅만 되어있어서 다음 이슈에서 API 완성하고 한번에 수정하겠습니당~~
heoboseong7
reviewed
Dec 18, 2022
|
|
||
| @Override | ||
| public String upload(MultipartFile multipartFile) { | ||
| String s3FileName = UUID.randomUUID() + "-" + multipartFile.getOriginalFilename(); |
There was a problem hiding this comment.
네이밍 규칙은 메서드로 빼는게 어떨까요?
heoboseong7
approved these changes
Dec 18, 2022
|
dev 스토어 ymal 업데이트 필요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.