[Feat] 마이페이지 유저 정보 조회 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
heoboseong7
commented
Dec 11, 2022
heoboseong7
commented
- 마이 페이지 유저 정보 조회
- userId를 통한 마이 페이지 조회
- 문서화용 테스트
- SecurityConfig SIGNUP_URL 수정
- ~/user/** -> ~/user/*로 수정
- 팔로우 토글의 isFollowing 파라미터 id 순서 수정
- close [Feat] 마이페이지 유저 정보 조회 #162
Youhoseong
reviewed
Dec 11, 2022
Comment on lines
16
to
17
| private List<String> interests; | ||
| private Boolean isFollow; |
There was a problem hiding this comment.
지금까지 팔로우 관련은 primitive한 boolean으로 나가고 있을거라 Json으로 변환되면
follow로 나갈건데요 통일하는건 어때요?
Youhoseong
reviewed
Dec 11, 2022
Comment on lines
46
to
47
| Long followingCount = profileDomainService.getFollowingCount(targetUser); | ||
| String challengeName = challengeDomainService.findCurrentParticipationWithChallenge(targetId) |
Youhoseong
reviewed
Dec 11, 2022
Comment on lines
+134
to
+135
|
|
||
| ResultActions resultActions = mockMvc.perform(get("/api/v1/user/profile/{targetId}", 1L) |
There was a problem hiding this comment.
저도 여기 하면서 컨트롤러들이 너무 도메인 중심으로 나눠진 것 같더라구요 ㅠ
마이 페이지 관련 부분을 아예 MyPageController로 만들어 보는건 어떨까요?
There was a problem hiding this comment.
페이지 단위로 컨트롤러를 떼는건 현재 저희 구조랑 잘 맞아보이진 않는거같아요 ㅜ
일단 이러케..
Youhoseong
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.