[Feat] 1일마다 챌린지 기록 검사 배치 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youhoseong
reviewed
Nov 24, 2022
| @Configuration | ||
| @RequiredArgsConstructor | ||
| @Slf4j | ||
| @ConditionalOnProperty(name ="job.name", havingValue = JOB_NAME) |
Youhoseong
reviewed
Nov 24, 2022
|
|
||
| private final InsightDomainService insightDomainService; | ||
|
|
||
| private final int chunkSize = 10; |
There was a problem hiding this comment.
chunkSize 기준을 어떻게 세우셨나요??
There was a problem hiding this comment.
기준을 생각하고 설정하지 않았었어요.
찾아보니 100~1000건 정도가 일반적인거 같은데, 아담한 저희의 인스턴스를 위해 우선 100으로 하는건 어떨까요?
Youhoseong
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.