[Feat] 챌린지 참여 여부 API #82 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heoboseong7
reviewed
Sep 12, 2022
Comment on lines
+44
to
+46
| public boolean checkParticipation(Long userId) { | ||
| return challengeParticipationRepository.existsByChallengerIdAndStatus(userId, CHALLENGING); | ||
| } |
There was a problem hiding this comment.
existsByChallengerIdAndStatus 이거 Data JPA가 만들어주는 쿼리는 불필요한 join이 나가지 않나요?
There was a problem hiding this comment.
요거 지금 native query 달려있는 그거입니당
There was a problem hiding this comment.
@query 달려있는 부분은 count의 문제네요 ㅎㅎ;;
Youhoseong
reviewed
Sep 12, 2022
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) |
There was a problem hiding this comment.
지나가다가 ㅜㅜ 들립니다
jpa 영역이아니다보니 PROTECTED말고 PRIVATE이어도 될듯해요
Youhoseong
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"data": {
"participation": false
}