Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spooker on workflow completion #126

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Run spooker on workflow completion #126

merged 9 commits into from
Oct 31, 2023

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Oct 30, 2023

Changes

  • Run spooker on workflow completion
    • In nextflow, the onCompletion handler runs regardless of success or failure.
  • Print a warning message if spooker cannot run (e.g. if it's not in the path or is not executable), but don't fail.

Issues

Resolves #110

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes. on hold until before public release
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool

This comment was marked as outdated.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review October 30, 2023 23:24
because other functions that call it don't seem to wait for the process to actually complete
before trying to use the output
@kelly-sovacool kelly-sovacool merged commit 8302666 into main Oct 31, 2023
2 checks passed
@kelly-sovacool kelly-sovacool deleted the spooker branch October 31, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run spooker on workflow completion
1 participant