Skip to content

Commit

Permalink
[Inventory] Remove Actions tooltip (elastic#201231)
Browse files Browse the repository at this point in the history
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.
  • Loading branch information
rmyz authored and CAWilson94 committed Dec 12, 2024
1 parent 02776b3 commit 0645b32
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ export const getColumns = ({
id: 'actions' as const,
// keep it for accessibility purposes
displayAsText: entityActionsLabel,
display: (
<CustomHeaderCell title={entityActionsLabel} tooltipContent={entityActionsLabel} />
),
display: <span>{entityActionsLabel}</span>,
initialWidth: 100,
},
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export function EntitiesGrid({
<EuiText size="s">
<FormattedMessage
id="xpack.inventory.entitiesGrid.euiDataGrid.headerLeft"
defaultMessage="Showing {currentItems} of {total} {boldEntites}"
defaultMessage="Showing {currentItems} of {total} {boldEntities}"
values={{
currentItems: (
<strong>
Expand All @@ -169,10 +169,10 @@ export function EntitiesGrid({
</strong>
),
total: entities.length,
boldEntites: (
boldEntities: (
<strong>
{i18n.translate(
'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites',
'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities',
{ defaultMessage: 'Entities' }
)}
</strong>
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -26176,8 +26176,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "Le nombre d'alertes actives",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "Nom de l'entité",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "Nom de l'entité (entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntites}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "Entités",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntities}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "Entités",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "Grille des entités d'inventaire",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} à {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "Vu en dernier",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -26148,8 +26148,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "アクティブなアラートの件数",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "エンティティ名",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "エンティティの名前(entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntites}を表示中",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "エンティティ",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntities}を表示中",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "エンティティ",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "インベントリエンティティグリッド",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "前回の認識",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -25678,8 +25678,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "活动告警计数",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "实体名称",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "实体的名称 (entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个(共 {total} 个){boldEntites}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "实体",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个(共 {total} 个){boldEntities}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "实体",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "库存实体网格",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "最后看到时间",
Expand Down

0 comments on commit 0645b32

Please sign in to comment.