Run benchmarks in the correct context and compare main vs PR #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwmunster
force-pushed
the
bugfix/benchmark-actions
branch
2 times, most recently
from
dd8e457
to
aaabe5f
Compare
|
The original version, which was force-pushed away, was generated with the "help" of AI and didn't actually work. The version present now is based on the Bencher docs. |
dwmunster
changed the title
dwmunster
force-pushed
the
bugfix/benchmark-actions
branch
from
aaabe5f
to
511fe12
Compare
dwmunster
force-pushed
the
bugfix/benchmark-actions
branch
from
511fe12
to
90e4002
Compare
bo0tzz
reviewed
Jun 4, 2024
|
Definitely appreciate the review @bo0tzz! |
dwmunster
added a commit
to dwmunster/ISOtope
that referenced
this pull request
Jun 4, 2024
…-Co#28) * Split benchmarks into a run and a comment workflow * Use explicit paths rather than glob for benchmark results Co-authored-by: bo0tzz <[email protected]> * Benchmark: Use default pull_request events --------- Co-authored-by: bo0tzz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attempts to fix two issues:
mainand the PR to ease comparisons.main, not the PR.Details
This PR splits the benchmarking workflow into two pieces:
pull_requestcontext (i.e., from the fork) that executes the code and uploads the results.workflow_runcontext (i.e., from CADmium-Co/ISOtope) that downloads the results and prints them in a comment.Running untrusted code is recommended in the
pull_requestcontext since it runs in the context of the fork and, thus, would have no access to any secrets or other branches. Theworkflow_runpiece is necessary to post the comment since the action running in thepull_requestcontext has read-only permissions and is unable to post/edit comments on the PR.