Extend cstr8! to accept [u8] and CStr checked at compile time
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kupiakos
changed the title
[u8] and CStr checked at compile timecstr8! to accept [u8] and CStr checked at compile time
kupiakos
force-pushed
the
macro-betterification
branch
from
ed4c1a4
to
e55ece0
Compare
kupiakos
force-pushed
the
macro-betterification
branch
from
e55ece0
to
a24657c
Compare
CAD97
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
I just have some minor style notes on the docs, but I'll tweak that myself before publishing. Thanks for the improvements!
I'm a little embarrassed that, buried in more advanced macro specialization techniques, I forgot that just making multiple implementations on a generic is sufficient for concretely finite sets of types 🙃 (although in my defense it's generally a good idea to avoid this kind of overloading in APIs such that Type::method is a single item)
|
Released in version 0.1.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
cstr8!to accept all of these types:&str&CStr&[u8]&[u8; N][u8; N]