Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use v7 on Balfrin #1033

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

use v7 on Balfrin #1033

wants to merge 3 commits into from

Conversation

jonasjucker
Copy link
Contributor

@jonasjucker jonasjucker commented Nov 21, 2024

icon-nwp is set to v7 already for some time.
Should be desirable to be alligned with spack-c2sm as well

Copy link
Contributor

github-actions bot commented Nov 21, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://C2SM.github.io/spack-c2sm/pr-preview/pr-1033/
on branch gh-pages at 2024-11-26 08:07 UTC

@jonasjucker
Copy link
Contributor Author

launch jenkins

@jonasjucker
Copy link
Contributor Author

launch jenkins

Copy link
Contributor

@dominichofer dominichofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to align spack-c2sm with production, which uses $USER_ENV_ROOT, which is set to v6 atm. But let's discuss at today's meeting.

@dominichofer
Copy link
Contributor

@huppd @lxavier @dominichofer discussed this and concluded that in the big picture it makes sense to use a fixed version and probably in most cases the newest version.
So we welcome this pull request 👍

@dominichofer dominichofer self-requested a review November 26, 2024 22:24
Copy link
Contributor

@dominichofer dominichofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants