Added style rules for arguments of Liskov directives to style-guide #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run default |
|
launch jenkins spack |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
huppd
approved these changes
Apr 10, 2024
iomaganaris
referenced
this pull request
in iomaganaris/icon4py
Jun 18, 2024
…#424) * Added style rules for arguments of Liskov directives * Small Markdown style changes * Reverted changes to indentation * Removed space after semi-colon --------- Co-authored-by: Mikael Stellio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Liskov style-guide adding guidelines on how we should format
!$DSL STENCILand!$DSL DECLAREdirectives and their arguments. These style choices were discussed together with @huppd and @muellch.Also, note that whitespaces in the
nameargument for stencils were not previously supported, but this will be added by PR #414.