Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import gtfn backends exposed by next module (cached version) #361

Merged
merged 14 commits into from
Feb 16, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Jan 24, 2024

Replace GTFN backend with the GTFN-cached backend exposed by gt4py.next module.

@edopao edopao marked this pull request as ready for review February 9, 2024 12:16
@edopao
Copy link
Contributor Author

edopao commented Feb 9, 2024

@havogt The icon-exclaim CI fails with error:
AttributeError: 'GTFNTranslationStep' object has no attribute 'generate_stencil_source'

Do you think this could be caused by the GTFN-cached backend? This PR is only modifying the pytest config, as far as I understand.

@edopao
Copy link
Contributor Author

edopao commented Feb 12, 2024

launch jenkins icon

@edopao
Copy link
Contributor Author

edopao commented Feb 13, 2024

@havogt The icon-exclaim CI fails with error: AttributeError: 'GTFNTranslationStep' object has no attribute 'generate_stencil_source'

Do you think this could be caused by the GTFN-cached backend? This PR is only modifying the pytest config, as far as I understand.

The last 2 commits revert the GTFN backend to use explicit classes. I wanted to run the icon-exclaim CI with the baseline backend (non-cached GTFN-backend). The CI still fails, with the same error, so it looks like an issue in baseline.

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@edopao
Copy link
Contributor Author

edopao commented Feb 16, 2024

launch jenkins spack

@edopao
Copy link
Contributor Author

edopao commented Feb 16, 2024

cscs-ci run default

@edopao
Copy link
Contributor Author

edopao commented Feb 16, 2024

cscs-ci run benchmark

@edopao edopao merged commit bf9cc87 into main Feb 16, 2024
6 checks passed
@edopao edopao deleted the gtfn-benchmark branch February 16, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants