Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diamond to gridmanager #352

Merged
merged 28 commits into from
Feb 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
aac1f68
function skeleton for diamond edges
halungge Jan 5, 2024
ea57d19
wip(1)
halungge Jan 5, 2024
dd165c4
keep order when unifying indices
halungge Jan 5, 2024
1f4cf3a
add e2ce2 and fix e2c2v
halungge Jan 8, 2024
2bdeb68
refactor diamond calculations
halungge Jan 9, 2024
d1069f5
add E2C2EODim connectivity
halungge Jan 9, 2024
fbc0221
Merge branch 'main' into add_diamond_to_gridmanager
halungge Jan 9, 2024
b15c3cf
add C2V in offset provider mapping
halungge Jan 9, 2024
534042e
add tests for R02B04_R.nc
halungge Jan 12, 2024
2341106
add test for domain bounds for global grid file
halungge Jan 17, 2024
e005013
use cached gridfile in tests
halungge Jan 17, 2024
603e33d
pre-commit fixes
halungge Jan 18, 2024
a13f4bb
Merge branch 'main' into add_diamond_to_gridmanager
halungge Jan 18, 2024
3d73048
revert changes in icon_grid
halungge Jan 18, 2024
11dd011
add docstrings
halungge Jan 22, 2024
1c0749a
review fixes in utils.py
halungge Jan 22, 2024
e1fde4c
rework tests
halungge Jan 23, 2024
3f43463
Merge branch 'main' into add_diamond_to_gridmanager
halungge Jan 23, 2024
b99e820
extract constants and remove serialbox comparison from test_grid_mana…
halungge Jan 24, 2024
f087703
extract constants (WIP)
halungge Jan 25, 2024
f5833e6
extract constants for domain bounds (WIP)
halungge Feb 1, 2024
48f1397
extract domain starts for local grid into constants
halungge Feb 5, 2024
2dd81cb
Merge branch 'main' into add_diamond_to_gridmanager
halungge Feb 5, 2024
a642572
pre-commit
halungge Feb 5, 2024
74c215f
(FIXES) ad hoc fixes
halungge Feb 5, 2024
a9f0d19
rename loop variables
halungge Feb 5, 2024
256786e
merge main
halungge Feb 6, 2024
8240059
(UNDO) remove default value from construct_icon grid
halungge Feb 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
(UNDO) remove default value from construct_icon grid
halungge committed Feb 6, 2024
commit 82400598d527138ee95dab50744550f7b19ca5c7
Original file line number Diff line number Diff line change
@@ -314,7 +314,7 @@ def _get_decomp_fields(self, dim: Dimension):
mask = self.owner_mask(dim)[0 : self.num(dim)]
return dim, global_index, mask

def construct_icon_grid(self, on_gpu: bool = False) -> IconGrid:
def construct_icon_grid(self, on_gpu: bool) -> IconGrid:
cell_starts = self.cells_start_index()
cell_ends = self.cells_end_index()
vertex_starts = self.vertex_start_index()