Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for new gt4py default backend #318

Merged
merged 17 commits into from
Nov 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def btraj_dreg_stencil_01_numpy(
return lvn_sys_pos


def test_btraj_dreg_stencil_01():
def test_btraj_dreg_stencil_01(backend):
grid = SimpleGrid()
lcounterclock = True
p_vn = random_field(grid, EdgeDim, KDim)
Expand All @@ -48,16 +48,16 @@ def test_btraj_dreg_stencil_01():

ref = btraj_dreg_stencil_01_numpy(
lcounterclock,
np.asarray(p_vn),
np.asarray(tangent_orientation),
p_vn.asnumpy(),
tangent_orientation.asnumpy(),
)

btraj_dreg_stencil_01(
btraj_dreg_stencil_01.with_backend(backend)(
lcounterclock,
p_vn,
tangent_orientation,
lvn_sys_pos,
offset_provider={},
)

assert np.allclose(ref, lvn_sys_pos)
assert np.allclose(ref, lvn_sys_pos.asnumpy())
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@
from icon4py.model.atmosphere.advection.btraj_dreg_stencil_02 import btraj_dreg_stencil_02
from icon4py.model.common.dimension import E2CDim, ECDim, EdgeDim, KDim
from icon4py.model.common.grid.simple import SimpleGrid
from icon4py.model.common.test_utils.helpers import as_1D_sparse_field, random_field, zero_field
from icon4py.model.common.test_utils.helpers import (
numpy_to_1D_sparse_field,
random_field,
zero_field,
)


def btraj_dreg_stencil_02_numpy(
Expand All @@ -43,20 +47,18 @@ def btraj_dreg_stencil_02_numpy(
return opt_famask_dsl


def test_btraj_dreg_stencil_02():
def test_btraj_dreg_stencil_02(backend):
grid = SimpleGrid()
p_vn = random_field(grid, EdgeDim, KDim)
p_vt = random_field(grid, EdgeDim, KDim)
edge_cell_length = np.asarray(grid.connectivities[E2CDim], dtype=float)
edge_cell_length_new = as_1D_sparse_field(edge_cell_length, ECDim)
edge_cell_length_new = numpy_to_1D_sparse_field(edge_cell_length, ECDim)
p_dt = 1.0
opt_famask_dsl = zero_field(grid, EdgeDim, KDim, dtype=int32)

ref = btraj_dreg_stencil_02_numpy(
np.asarray(p_vn), np.asarray(p_vt), np.asarray(edge_cell_length), p_dt
)
ref = btraj_dreg_stencil_02_numpy(p_vn.asnumpy(), p_vt.asnumpy(), edge_cell_length, p_dt)

btraj_dreg_stencil_02(
btraj_dreg_stencil_02.with_backend(backend)(
p_vn,
p_vt,
edge_cell_length_new,
Expand All @@ -68,4 +70,4 @@ def test_btraj_dreg_stencil_02():
},
)

assert np.allclose(ref, opt_famask_dsl)
assert np.allclose(ref, opt_famask_dsl.asnumpy())
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@

import numpy as np
from gt4py.next.ffront.fbuiltins import int32
from gt4py.next.iterator.embedded import StridedNeighborOffsetProvider

from icon4py.model.atmosphere.advection.btraj_dreg_stencil_03 import btraj_dreg_stencil_03
from icon4py.model.common.dimension import E2CDim, ECDim, EdgeDim, KDim
from icon4py.model.common.grid.simple import SimpleGrid
from icon4py.model.common.test_utils.helpers import as_1D_sparse_field, constant_field, random_field
from icon4py.model.common.test_utils.helpers import (
as_1D_sparse_field,
constant_field,
numpy_to_1D_sparse_field,
random_field,
)


def btraj_dreg_stencil_03_numpy(
Expand Down Expand Up @@ -107,13 +111,13 @@ def btraj_dreg_stencil_03_numpy(
)


def test_btraj_dreg_stencil_03():
def test_btraj_dreg_stencil_03(backend):
grid = SimpleGrid()

p_vn = random_field(grid, EdgeDim, KDim)
p_vt = random_field(grid, EdgeDim, KDim)
cell_idx = np.asarray(grid.connectivities[E2CDim], dtype=int32)
cell_idx_new = as_1D_sparse_field(cell_idx, ECDim)
cell_idx_new = numpy_to_1D_sparse_field(cell_idx, ECDim)
cell_blk = constant_field(grid, 1, EdgeDim, E2CDim, dtype=int32)
cell_blk_new = as_1D_sparse_field(cell_blk, ECDim)

Expand Down Expand Up @@ -160,27 +164,27 @@ def test_btraj_dreg_stencil_03():
p_coords_dreg_v_3_lat_dsl_ref,
p_coords_dreg_v_4_lat_dsl_ref,
) = btraj_dreg_stencil_03_numpy(
np.asarray(p_vn),
np.asarray(p_vt),
np.asarray(cell_idx),
np.asarray(cell_blk),
np.asarray(edge_verts_1_x),
np.asarray(edge_verts_2_x),
np.asarray(edge_verts_1_y),
np.asarray(edge_verts_2_y),
np.asarray(pos_on_tplane_e_1_x),
np.asarray(pos_on_tplane_e_2_x),
np.asarray(pos_on_tplane_e_1_y),
np.asarray(pos_on_tplane_e_2_y),
np.asarray(primal_normal_cell_x),
np.asarray(primal_normal_cell_y),
np.asarray(dual_normal_cell_x),
np.asarray(dual_normal_cell_y),
np.asarray(lvn_sys_pos),
p_vn.asnumpy(),
p_vt.asnumpy(),
cell_idx,
cell_blk.asnumpy(),
edge_verts_1_x.asnumpy(),
edge_verts_2_x.asnumpy(),
edge_verts_1_y.asnumpy(),
edge_verts_2_y.asnumpy(),
pos_on_tplane_e_1_x.asnumpy(),
pos_on_tplane_e_2_x.asnumpy(),
pos_on_tplane_e_1_y.asnumpy(),
pos_on_tplane_e_2_y.asnumpy(),
primal_normal_cell_x.asnumpy(),
primal_normal_cell_y.asnumpy(),
dual_normal_cell_x.asnumpy(),
dual_normal_cell_y.asnumpy(),
lvn_sys_pos.asnumpy(),
p_dt,
)

btraj_dreg_stencil_03(
btraj_dreg_stencil_03.with_backend(backend)(
p_vn,
p_vt,
cell_idx_new,
Expand Down Expand Up @@ -212,17 +216,17 @@ def test_btraj_dreg_stencil_03():
p_coords_dreg_v_4_lat_dsl,
offset_provider={
"E2C": grid.get_offset_provider("E2C"),
"E2EC": StridedNeighborOffsetProvider(EdgeDim, ECDim, grid.size[E2CDim]),
"E2EC": grid.get_offset_provider("E2EC"),
},
)
assert np.allclose(p_cell_idx, p_cell_idx_ref)
assert np.allclose(p_cell_rel_idx_dsl, p_cell_rel_idx_dsl_ref)
assert np.allclose(p_cell_blk, p_cell_blk_ref)
assert np.allclose(p_coords_dreg_v_1_lon_dsl, p_coords_dreg_v_1_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_2_lon_dsl, p_coords_dreg_v_2_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_3_lon_dsl, p_coords_dreg_v_3_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_4_lon_dsl, p_coords_dreg_v_4_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_1_lat_dsl, p_coords_dreg_v_1_lat_dsl_ref)
assert np.allclose(p_coords_dreg_v_2_lat_dsl, p_coords_dreg_v_2_lat_dsl_ref)
assert np.allclose(p_coords_dreg_v_3_lat_dsl, p_coords_dreg_v_3_lat_dsl_ref)
assert np.allclose(p_coords_dreg_v_4_lat_dsl, p_coords_dreg_v_4_lat_dsl_ref)
assert np.allclose(p_cell_idx.asnumpy(), p_cell_idx_ref)
assert np.allclose(p_cell_rel_idx_dsl.asnumpy(), p_cell_rel_idx_dsl_ref)
assert np.allclose(p_cell_blk.asnumpy(), p_cell_blk_ref)
assert np.allclose(p_coords_dreg_v_1_lon_dsl.asnumpy(), p_coords_dreg_v_1_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_2_lon_dsl.asnumpy(), p_coords_dreg_v_2_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_3_lon_dsl.asnumpy(), p_coords_dreg_v_3_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_4_lon_dsl.asnumpy(), p_coords_dreg_v_4_lon_dsl_ref)
assert np.allclose(p_coords_dreg_v_1_lat_dsl.asnumpy(), p_coords_dreg_v_1_lat_dsl_ref)
assert np.allclose(p_coords_dreg_v_2_lat_dsl.asnumpy(), p_coords_dreg_v_2_lat_dsl_ref)
assert np.allclose(p_coords_dreg_v_3_lat_dsl.asnumpy(), p_coords_dreg_v_3_lat_dsl_ref)
assert np.allclose(p_coords_dreg_v_4_lat_dsl.asnumpy(), p_coords_dreg_v_4_lat_dsl_ref)
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ def divide_flux_area_list_stencil_01_numpy(


@pytest.mark.slow_tests
def test_divide_flux_area_list_stencil_01():
def test_divide_flux_area_list_stencil_01(backend):
grid = SimpleGrid()

famask_int = random_mask(grid, EdgeDim, KDim, dtype=int32)
Expand Down Expand Up @@ -738,7 +738,7 @@ def test_divide_flux_area_list_stencil_01():
np.asarray(dreg_patch0_4_lat_dsl),
)

divide_flux_area_list_stencil_01(
divide_flux_area_list_stencil_01.with_backend(backend)(
famask_int,
p_vn,
ptr_v3_lon_field,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def divide_flux_area_list_stencil_02_numpy(
)


def test_divide_flux_area_list_stencil_02():
def test_divide_flux_area_list_stencil_02(backend):
grid = SimpleGrid()

famask_int = random_mask(grid, EdgeDim, KDim, dtype=int32)
Expand Down Expand Up @@ -239,39 +239,39 @@ def test_divide_flux_area_list_stencil_02():
ref_20,
) = divide_flux_area_list_stencil_02_numpy(
grid.connectivities[E2CDim],
np.asarray(famask_int),
np.asarray(p_vn),
np.asarray(bf_cc_patch1_lon),
np.asarray(bf_cc_patch1_lat),
np.asarray(bf_cc_patch2_lon),
np.asarray(bf_cc_patch2_lat),
np.asarray(butterfly_idx_patch1_vnpos),
np.asarray(butterfly_idx_patch1_vnneg),
np.asarray(butterfly_blk_patch1_vnpos),
np.asarray(butterfly_blk_patch1_vnneg),
np.asarray(butterfly_idx_patch2_vnpos),
np.asarray(butterfly_idx_patch2_vnneg),
np.asarray(butterfly_blk_patch2_vnpos),
np.asarray(butterfly_blk_patch2_vnneg),
np.asarray(dreg_patch1_1_lon_vmask),
np.asarray(dreg_patch1_1_lat_vmask),
np.asarray(dreg_patch1_2_lon_vmask),
np.asarray(dreg_patch1_2_lat_vmask),
np.asarray(dreg_patch1_3_lon_vmask),
np.asarray(dreg_patch1_3_lat_vmask),
np.asarray(dreg_patch1_4_lon_vmask),
np.asarray(dreg_patch1_4_lat_vmask),
np.asarray(dreg_patch2_1_lon_vmask),
np.asarray(dreg_patch2_1_lat_vmask),
np.asarray(dreg_patch2_2_lon_vmask),
np.asarray(dreg_patch2_2_lat_vmask),
np.asarray(dreg_patch2_3_lon_vmask),
np.asarray(dreg_patch2_3_lat_vmask),
np.asarray(dreg_patch2_4_lon_vmask),
np.asarray(dreg_patch2_4_lat_vmask),
famask_int.asnumpy(),
p_vn.asnumpy(),
bf_cc_patch1_lon.asnumpy(),
bf_cc_patch1_lat.asnumpy(),
bf_cc_patch2_lon.asnumpy(),
bf_cc_patch2_lat.asnumpy(),
butterfly_idx_patch1_vnpos.asnumpy(),
butterfly_idx_patch1_vnneg.asnumpy(),
butterfly_blk_patch1_vnpos.asnumpy(),
butterfly_blk_patch1_vnneg.asnumpy(),
butterfly_idx_patch2_vnpos.asnumpy(),
butterfly_idx_patch2_vnneg.asnumpy(),
butterfly_blk_patch2_vnpos.asnumpy(),
butterfly_blk_patch2_vnneg.asnumpy(),
dreg_patch1_1_lon_vmask.asnumpy(),
dreg_patch1_1_lat_vmask.asnumpy(),
dreg_patch1_2_lon_vmask.asnumpy(),
dreg_patch1_2_lat_vmask.asnumpy(),
dreg_patch1_3_lon_vmask.asnumpy(),
dreg_patch1_3_lat_vmask.asnumpy(),
dreg_patch1_4_lon_vmask.asnumpy(),
dreg_patch1_4_lat_vmask.asnumpy(),
dreg_patch2_1_lon_vmask.asnumpy(),
dreg_patch2_1_lat_vmask.asnumpy(),
dreg_patch2_2_lon_vmask.asnumpy(),
dreg_patch2_2_lat_vmask.asnumpy(),
dreg_patch2_3_lon_vmask.asnumpy(),
dreg_patch2_3_lat_vmask.asnumpy(),
dreg_patch2_4_lon_vmask.asnumpy(),
dreg_patch2_4_lat_vmask.asnumpy(),
)

divide_flux_area_list_stencil_02(
divide_flux_area_list_stencil_02.with_backend(backend)(
famask_int,
p_vn,
bf_cc_patch1_lon_field,
Expand Down Expand Up @@ -311,23 +311,23 @@ def test_divide_flux_area_list_stencil_02():
"E2EC": StridedNeighborOffsetProvider(EdgeDim, ECDim, grid.size[E2CDim]),
},
)
assert np.allclose(dreg_patch1_1_lon_vmask, ref_1)
assert np.allclose(dreg_patch1_1_lat_vmask, ref_2)
assert np.allclose(dreg_patch1_2_lon_vmask, ref_3)
assert np.allclose(dreg_patch1_2_lat_vmask, ref_4)
assert np.allclose(dreg_patch1_3_lon_vmask, ref_5)
assert np.allclose(dreg_patch1_3_lat_vmask, ref_6)
assert np.allclose(dreg_patch1_4_lon_vmask, ref_7)
assert np.allclose(dreg_patch1_4_lat_vmask, ref_8)
assert np.allclose(dreg_patch2_1_lon_vmask, ref_9)
assert np.allclose(dreg_patch2_1_lat_vmask, ref_10)
assert np.allclose(dreg_patch2_2_lon_vmask, ref_11)
assert np.allclose(dreg_patch2_2_lat_vmask, ref_12)
assert np.allclose(dreg_patch2_3_lon_vmask, ref_13)
assert np.allclose(dreg_patch2_3_lat_vmask, ref_14)
assert np.allclose(dreg_patch2_4_lon_vmask, ref_15)
assert np.allclose(dreg_patch2_4_lat_vmask, ref_16)
assert np.allclose(patch1_cell_idx_vmask, ref_17)
assert np.allclose(patch1_cell_blk_vmask, ref_18)
assert np.allclose(patch2_cell_idx_vmask, ref_19)
assert np.allclose(patch2_cell_blk_vmask, ref_20)
assert np.allclose(dreg_patch1_1_lon_vmask.asnumpy(), ref_1)
assert np.allclose(dreg_patch1_1_lat_vmask.asnumpy(), ref_2)
assert np.allclose(dreg_patch1_2_lon_vmask.asnumpy(), ref_3)
assert np.allclose(dreg_patch1_2_lat_vmask.asnumpy(), ref_4)
assert np.allclose(dreg_patch1_3_lon_vmask.asnumpy(), ref_5)
assert np.allclose(dreg_patch1_3_lat_vmask.asnumpy(), ref_6)
assert np.allclose(dreg_patch1_4_lon_vmask.asnumpy(), ref_7)
assert np.allclose(dreg_patch1_4_lat_vmask.asnumpy(), ref_8)
assert np.allclose(dreg_patch2_1_lon_vmask.asnumpy(), ref_9)
assert np.allclose(dreg_patch2_1_lat_vmask.asnumpy(), ref_10)
assert np.allclose(dreg_patch2_2_lon_vmask.asnumpy(), ref_11)
assert np.allclose(dreg_patch2_2_lat_vmask.asnumpy(), ref_12)
assert np.allclose(dreg_patch2_3_lon_vmask.asnumpy(), ref_13)
assert np.allclose(dreg_patch2_3_lat_vmask.asnumpy(), ref_14)
assert np.allclose(dreg_patch2_4_lon_vmask.asnumpy(), ref_15)
assert np.allclose(dreg_patch2_4_lat_vmask.asnumpy(), ref_16)
assert np.allclose(patch1_cell_idx_vmask.asnumpy(), ref_17)
assert np.allclose(patch1_cell_blk_vmask.asnumpy(), ref_18)
assert np.allclose(patch2_cell_idx_vmask.asnumpy(), ref_19)
assert np.allclose(patch2_cell_blk_vmask.asnumpy(), ref_20)
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
# SPDX-License-Identifier: GPL-3.0-or-later

import numpy as np
from gt4py.next import as_field
from gt4py.next.ffront.fbuiltins import int32
from gt4py.next.iterator import embedded as it_embedded

from icon4py.model.atmosphere.advection.face_val_ppm_stencil_01 import face_val_ppm_stencil_01
from icon4py.model.common.dimension import CellDim, KDim
from icon4py.model.common.grid.simple import SimpleGrid
from icon4py.model.common.test_utils.helpers import _shape, random_field, zero_field
from icon4py.model.common.test_utils.helpers import _shape, random_field


def face_val_ppm_stencil_01_numpy(
Expand All @@ -27,7 +27,6 @@ def face_val_ppm_stencil_01_numpy(
vert_idx: np.array,
elev: int32,
):

# this is a comment: vert_idx = np.broadcast_to(vert_idx, p_cc.shape)

# 01a
Expand Down Expand Up @@ -61,27 +60,24 @@ def face_val_ppm_stencil_01_numpy(
return z_slope


def test_face_val_ppm_stencil_01():
def test_face_val_ppm_stencil_01(backend):
grid = SimpleGrid()
p_cc = random_field(grid, CellDim, KDim, extend={KDim: 1})
p_cellhgt_mc_now = random_field(grid, CellDim, KDim, extend={KDim: 1})
vert_idx = zero_field(grid, KDim, dtype=int32, extend={KDim: 1})

vert_idx = it_embedded.np_as_located_field(KDim)(
np.arange(0, _shape(grid, KDim, extend={KDim: 1})[0], dtype=int32)
)
vert_idx = as_field((KDim,), np.arange(0, _shape(grid, KDim, extend={KDim: 1})[0], dtype=int32))
elev = vert_idx[-2]

z_slope = random_field(grid, CellDim, KDim)

ref = face_val_ppm_stencil_01_numpy(
np.asarray(p_cc),
np.asarray(p_cellhgt_mc_now),
np.asarray(vert_idx),
p_cc.asnumpy(),
p_cellhgt_mc_now.asnumpy(),
vert_idx.asnumpy(),
elev,
)

face_val_ppm_stencil_01(
face_val_ppm_stencil_01.with_backend(backend)(
p_cc,
p_cellhgt_mc_now,
vert_idx,
Expand All @@ -90,4 +86,4 @@ def test_face_val_ppm_stencil_01():
offset_provider={"Koff": KDim},
)

assert np.allclose(ref[:, :-1], z_slope[:, 1:-1])
assert np.allclose(ref[:, :-1], z_slope.asnumpy()[:, 1:-1])
Loading