Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change float power to integer power #311

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Change float power to integer power #311

merged 2 commits into from
Nov 10, 2023

Conversation

huppd
Copy link
Contributor

@huppd huppd commented Nov 10, 2023

This PR changes the legacy float powers to integer powers.

@huppd
Copy link
Contributor Author

huppd commented Nov 10, 2023

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 10, 2023

launch jenkins spack

@huppd
Copy link
Contributor Author

huppd commented Nov 10, 2023

launch jenkins icon

@huppd huppd marked this pull request as ready for review November 10, 2023 12:34
@muellch muellch self-requested a review November 10, 2023 13:01
Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@huppd
Copy link
Contributor Author

huppd commented Nov 10, 2023

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 10, 2023

launch jenkins spack

@huppd
Copy link
Contributor Author

huppd commented Nov 10, 2023

launch jenkins icon

@huppd huppd merged commit f8004aa into main Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants