-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeloop #308
+1,119
−421
Merged
Timeloop #308
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
c164b13
Constructing time loop
OngChia 0f22f54
Constructing time loop
OngChia 1a4a7a8
COnstructing time loop test
OngChia f84cae2
Merge branch 'main' into timeloop
OngChia 80e4a62
Constructing timeloop
OngChia 9871226
Constructing time loop
OngChia 44dcf11
time loop under construction
OngChia 9b6c241
Created a test for timeloop
OngChia aa34553
Updated the time_step call in timeloop
OngChia 139ebb0
Finalizing timeloop and its test
OngChia f4924f5
Finalized timeloop before attempting to merge
OngChia 46dd017
Resolve conflicts
OngChia d81909f
Resolving pre-commit failed runs
OngChia fa46f6c
Attempting to resolve shadowing of Python builtin in stencil 14
OngChia 368cc57
Resolving A004 error code for abs import in dycore velocity_stencil 1…
OngChia fc315a1
Removed adding A004 to the flake8 ignore list in dycore
OngChia e86bb81
Resolving conflicts
OngChia df63714
Fixed bugs due to recent update of grid infrastructure, and add secon…
OngChia 510f4dd
CLeaning up timeloop
OngChia 9eae2c1
Resolved conflicts
OngChia 0d4dddd
Passed qa after resolving conflicts
OngChia a85e3ce
Resolving issues brought up in review
OngChia 4c3209e
Removed a bug in r04b09_iconrun_config where appla_initial_stabilizat…
OngChia 25ab752
Merge branch 'main' of https://github.com/C2SM/icon4py into timeloop
OngChia 4eab095
Made changes according to second review
OngChia c6461be
Made changes according to icon4py qa
OngChia 56b992f
Added TODO of diagnostic variable preparation in time_integration nec…
OngChia 664c80a
Update README.md of driver and change np.asarray to .asnumpy()
OngChia 066bd0b
Resolved conflicts with main branch, added tests for the second time …
OngChia 9485e34
Resolved conflicts
OngChia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Removed a bug in r04b09_iconrun_config where appla_initial_stabilizat…
…ion was wrongly set to true after the review
commit 4c3209ef1f53e05b8aaebaae0db65e318f36dd89
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you rename this function to
_validate_config
then you don't need the extra comment.