Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate stencil tests #281

Merged
merged 35 commits into from
Oct 12, 2023
Merged

Isolate stencil tests #281

merged 35 commits into from
Oct 12, 2023

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Sep 27, 2023 •
edited
Loading

Reorganize tests such that spack builds can run tests relevant for blue line without additional dependencies:

  • move unit tests for icon stencils into separate folders 'tests/stencil_tests'
  • make sure no conftest.py in the path of stencil_tests folders load additional dependencies.
  • add optional dependency block in icon4pytools for py2f (not used in blueline).

@halungge
- move stencil tests to their own module
5e5ac07 
- move fixtures for stencil tests into helpers.py and rename fixtures.py
@halungge
(fix) fix test: use explicit numpy cast for numpy slicing.
e8e148a
@halungge
(fix) pre-commit
29a457f
@halungge
Merge branch 'isolate_stencil_tests' of github.com:C2SM/icon4py into …
eadf66f 
…isolate_stencil_tests
@halungge
icon4pytools:
6e22e82 
- make cffi dependency optional.
- add missing diffusion package in requirements.txt
- rename code generation test
@halungge
move interpolation stencil tests to tests/stencil_test module
77c78ad
@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

1 similar comment
@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge halungge marked this pull request as ready for review September 28, 2023 08:12
@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
- remove tox.ini from root folder
3c390d7 
- install optional dependencies in requirements-dev.txt
egparedes
egparedes reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, just one question in the tests

model/common/tests/decomposition_tests/test_parallel_setup.py Outdated Show resolved Hide resolved
muellch
muellch approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand everything, but I think it is fine.

@halungge
Copy link
Contributor Author

halungge commented Oct 3, 2023

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Oct 3, 2023

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge halungge mentioned this pull request Oct 3, 2023
Merged
@halungge
Copy link
Contributor Author

halungge commented Oct 4, 2023

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

launch jenkins icon spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

jenkins launch icon spackProject=C2SM/simplify-icon4py-dependencies

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

cscs-ci run

@halungge
Copy link
Contributor Author

launch jenkins spack spackProject=C2SM/simplify-icon4py-dependencies

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge halungge merged commit 72f077a into main Oct 12, 2023
2 checks passed
@halungge halungge deleted the isolate_stencil_tests branch December 12, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellch muellch muellch approved these changes

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halungge @egparedes @muellch