Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind about tests #257

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Remind about tests #257

merged 7 commits into from
Aug 17, 2023

Conversation

jonasjucker
Copy link
Contributor

@jonasjucker jonasjucker commented Aug 16, 2023

Since people still merge PR w/o proper testing I add a reminder now!

Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, also the link to the CI overview in Exclaim is useful.

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@jonasjucker jonasjucker merged commit 4842cac into main Aug 17, 2023
@jonasjucker jonasjucker deleted the test_reminder branch August 17, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants