Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Multiline declaration handling fix created #239

Merged
merged 4 commits into from
Jul 12, 2023
Merged

WIP: Multiline declaration handling fix created #239

merged 4 commits into from
Jul 12, 2023

Conversation

ChristopherBignamini
Copy link
Contributor

No description provided.

samkellerhals
samkellerhals approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's test the serialisation once on tsa with the diffusion granule as a test case and then it should be good to go.

@samkellerhals samkellerhals marked this pull request as ready for review July 11, 2023 12:49
@samkellerhals samkellerhals merged commit 6108462 into main Jul 12, 2023
@samkellerhals samkellerhals deleted the f2ser_multiline_declaration_handling_fix branch July 12, 2023 11:31
@samkellerhals samkellerhals mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samkellerhals samkellerhals samkellerhals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristopherBignamini @samkellerhals