Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index stencils field view implementation #199

Merged
merged 14 commits into from
May 15, 2023
Merged

Index stencils field view implementation #199

merged 14 commits into from
May 15, 2023

Conversation

muellch
Copy link
Contributor

@muellch muellch commented May 1, 2023

Write field view representation for offset stencils

  • Adapt bindings generator to be able to handle compound fields who also have a sparse dimension (example Field[[CEDim, KDim], float].
  • Introduced a flatten_first_two_dims helper method to flatten the first two dimensions of a field, which need to be the two dimensions representing a dense and a sparse dimension (example Field[[EdgeDim, E2CDim, ...], float]), into a compound dimension (example Field[[ECDim, ...], float]).
  • Refactor sparse and compound location type, using a common base class there.

@muellch muellch changed the base branch from main to tracer_advection_stencils_hud May 1, 2023 22:46
@muellch muellch changed the base branch from tracer_advection_stencils_hud to main May 2, 2023 09:34
@nfarabullini nfarabullini self-requested a review May 10, 2023 12:37
Copy link
Contributor

@samkellerhals samkellerhals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@muellch muellch merged commit eea3bf8 into main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants