Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon4pygen namespace package #177

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

samkellerhals
Copy link
Contributor

Rename pyutils namespace package to icon4pygen since this makes more sense. Move the bindings subpackage inside icon4pygen since it is part of icon4pygen

@samkellerhals samkellerhals requested a review from havogt March 27, 2023 13:37
@havogt havogt requested review from halungge and removed request for havogt March 30, 2023 08:15
@havogt
Copy link
Contributor

havogt commented Mar 30, 2023

I think it makes sense. Maybe we need to rework the repo layout a bit more.

Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea would be that inside the pyutils src folder there could be several python packages, one of them being icon4pygen? That is, contrary to now there is no toplevel folder per python package but several of them can be grouped together.

I think this makes sense. We could in a similar way also group all the model code together (atm_dyn_iconam, advection, microphysics...)

@samkellerhals
Copy link
Contributor Author

After speaking to @halungge I realised this is indeed more of a structural change than only renaming. However this could result in a more cohesive layout of the repository overall. The suggestion would be to have a more hierarchical setup of folders at the top-level containing the different importable packages. For example:

model/
    atm_dyn_iconam
    icon_driver
    ...

tools/
    icon4pygen
    liskov
    f2ser
    ...

@samkellerhals samkellerhals merged commit c8b868a into main Mar 30, 2023
@samkellerhals samkellerhals deleted the rename-pyutils-to-icon4pygen branch March 30, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants