Add Fortran Serialisation Framework #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parse granule using f2py * Revert icon4pygen rename * Parse derived types (collect type info in dependencies) * Fully parse variables and inject line numbers * Improve parsing tests
* Add basic deserialisation * Add deserialiser and tests * Add basic savepoints * Move f90 sources to testutils * Create maximum two savepoints per subroutine
* Add basic structure * Fix tests * Add codegen templates * Add more codegen * Generate code in correct location * Cleanup and add docstrings * Remove todo * Update fortran granule
* CLI created * Input parameter renaming, dependencies made optional * Update cli.py --------- Co-authored-by: Samuel <[email protected]>
Introduces fixes to the f2ser code generation template.
* Remove superflous methods * cleanup
* No dependency test created * Missing dependency test added * Added test for non existing granule input file * Add small fixes --------- Co-authored-by: samkellerhals <[email protected]>
Co-authored-by: samkellerhals <[email protected]>
Merged
halungge
requested changes
May 17, 2023
pyutils/src/icon4py/icon4pygen/bindings/codegen/render/field.py
Outdated
Show resolved
Hide resolved
muellch
approved these changes
May 23, 2023
muellch
approved these changes
May 23, 2023
halungge
approved these changes
May 24, 2023
|
Alright, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a flexible framework for serializing Fortran execution to improve testing and performance optimizations.
Currently we foresee two use cases:
See https://hackmd.io/tPnjCjfjTjy2XJfHtffv3w?both
This PR introduces
f2ser: A Fortran Granule Interface Parser, which parses a given granule and generatesppserserialisation statements for each variable in theinitandrunsubroutines.Additions to to
liskov, enabling the generation ofppserserialisation statements using the--ppseroption.Build Integration
The changes in this PR https://github.com/C2SM/icon-exclaim/pull/159 are necessary for the liskov serialisation code to compile and run.