Fix: Invalid row index doesn't reflect original row count #130 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Fix grammar to make doc more professional
Fix grammar to make doc more professional
Install safer-buffer polyfill to maintain compatibility with node < 6. See https://nodejs.org/de/docs/guides/buffer-constructor-deprecation/#variant-2
Also, lock our node 4 to a known working version
V2 safe buffer initilization
* Updated to Node 8
* Rewrote in Typescript
* Calling the library as a function has been removed in favor of `csv.parse`.
* `csv()` change to `csv.parse()`
* Deprecated `fromString` in favor of `parseString`
* `csv.fromString()` change to `csv.parseString()`
* Deprecated `fromStream` in favor of `parseStream`a
* `csv.fromStream()` change to `csv.parseStream()`
* Deprecated`fromPath` in favor of `parseFile`
* `csv.fromPath()` change to `csv.parseFile()`
# Conflicts:
# .travis.yml
# Gruntfile.js
# History.md
# lib/formatter/formatter.js
# lib/formatter/formatter_stream.js
# package-lock.json
# package.json
Update lodash to v4.17.13
* Added tests for alternate encoding
|
I cherry-picked your change to clean up the history, and issued a new PR #268. Ill close this once I publish the new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A detailed report of the issue is reported in #130 .
Changes in this PR:
Previously an invalid row would reduce the total count of parsed rows (passed to the event-handler of
end). This caused the row number passed to the event-handler ofdata-invalidto be incorrect.This PR changes the value of
rowCountpassed to the event-handler ofendto be the total number of rows in the csv file and passes the absoluterowNumberto the event-handler ofdata-invalid.Existing tests were updated to reflect the change.