Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast-csv error stream issues #93

Closed
jgornick opened this issue Mar 12, 2015 · 2 comments
Closed

fast-csv error stream issues #93

jgornick opened this issue Mar 12, 2015 · 2 comments
Labels
bug

Comments

@jgornick
Copy link

I ran into an issue when using fast-csv and listening for the error event. It seems a fast-csv stream doesn't properly manage stream events. The example I have is I will thrown an exception outside of the stream and fast-csv stream error event will trigger instead of having it handled via the process.

Example can be found at https://gist.github.com/jgornick/cd2b8bf0d8ba76b5d747
doug-martin added a commit to doug-martin/fast-csv that referenced this issue Mar 13, 2015
@doug-martin
v0.6.0
248dd9d 
* Removed try catch from emit to allow bubbling up of errors to process, if one is thrown C2FO#93
    * This also fixed issue C2FO#92 where a loop was entered when `this.emit("error")` was called.
* Added new tests
@doug-martin doug-martin mentioned this issue Mar 13, 2015
Merged
doug-martin added a commit to doug-martin/fast-csv that referenced this issue Mar 13, 2015
@doug-martin
v0.6.0
3a5d376 
* Removed try catch from emit to allow bubbling up of errors to process, if one is thrown C2FO#93
    * This also fixed issue C2FO#92 where a loop was entered when `this.emit("error")` was called.
* Added new tests
doug-martin added a commit to doug-martin/fast-csv that referenced this issue Mar 13, 2015
@doug-martin
v0.6.0
f0a0e85 
* Removed try catch from emit to allow bubbling up of errors to process, if one is thrown C2FO#93
    * This also fixed issue C2FO#92 where a loop was entered when `this.emit("error")` was called.
* Added new tests
@doug-martin
Copy link
Contributor

Hi Joe,

Found the issue and it should be resolved with v0.6.0 please let me know if you have any issues.

-Doug

@jgornick
Copy link
Author

@doug-martin Awesomesauce. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgornick @doug-martin